Skip to content

Fixed bug #62073 (Different ways of iterating over an SplMaxHeap result in in different keys) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2012
Merged

Fixed bug #62073 (Different ways of iterating over an SplMaxHeap result in in different keys) #90

merged 1 commit into from
May 24, 2012

Conversation

@reeze
Copy link
Contributor

@reeze reeze commented May 23, 2012

Hi,
In this commit http://svn.php.net/viewvc?view=revision&revision=269522
it set the current key value to heap.count - 1 but leave foreach iterator unchanged.

This also changed the affected tests files.

Thanks.

@laruence
Copy link
Member

laruence commented May 23, 2012

anyway, I think the fix is okey, if no objection raise in couple of days, I will merge this. thanks

@php-pulls php-pulls merged commit 9205c4f into php:PHP-5.3 May 24, 2012
@laruence
Copy link
Member

laruence commented May 24, 2012

I edited the test script. and merged, closed

@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reeze @laruence @php-pulls